Added .env files to the react project templates in order to run the CRA server independently. #13525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-mvc
mkArtakMSFT
requested review from
danroth27 and
ryanbrandenburg
and removed request for
Tratcher and
analogrelay
mkArtakMSFT
reviewed
Aug 29, 2019
src/Middleware/NodeServices/src/HostingModels/NodeInvocationException.cs
Outdated
Show resolved
Hide resolved
mkArtakMSFT
approved these changes
Aug 30, 2019
Contributor
mkArtakMSFT
left a comment
mkArtakMSFT
left a comment
There was a problem hiding this comment.
Thanks @dannyBies.
@danroth27 given this is change on the template level, would be great to have your signoff on this too.
ryanbrandenburg
approved these changes
Aug 30, 2019
Contributor
|
Thanks for the PR, @dannyBies. |
dougbu
added a commit
to dotnet-maestro-bot/AspNetCore
that referenced
this pull request
Sep 22, 2019
- follow-up to 026b9df / dotnet#13525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .env files to the react project templates in order to run the CRA server independently.
PR based on #12435
Fixes #7286