Skip to content

Add a few more HandshakeRequest parsing tests #13397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikaelm12 merged 3 commits into from
Aug 27, 2019
Merged

Add a few more HandshakeRequest parsing tests #13397

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9d4e12
Add a few more handshake request parsing tests
mikaelm12 Aug 23, 2019
581f48e
newline
mikaelm12 Aug 23, 2019
8283506
pr fb
mikaelm12 Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/SignalR/common/SignalR.Common/test/Internal/Protocol/HandshakeProtocolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ public class HandshakeProtocolTests
[InlineData("{\"protocol\":\"dummy\",\"version\":1}\u001e", "dummy", 1)]
[InlineData("{\"protocol\":\"\",\"version\":10}\u001e", "", 10)]
[InlineData("{\"protocol\":\"\",\"version\":10,\"unknown\":null}\u001e", "", 10)]
[InlineData("{\"protocol\":\"firstProtocol\",\"protocol\":\"secondProtocol\",\"version\":1}\u001e", "secondProtocol", 1)]
[InlineData("{\"protocol\":\"firstProtocol\",\"protocol\":\"secondProtocol\",\"version\":1,\"version\":75}\u001e", "secondProtocol", 75)]
[InlineData("{\"protocol\":\"dummy\",\"version\":1,\"ignoredField\":99}\u001e", "dummy", 1)]
Copy link
Member

@halter73 halter73 Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if there's multiple json objects prior to the \u001e delimiter.

Copy link
Member

@BrennanConroy BrennanConroy Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests for escaped property names too

Copy link
Contributor Author

@mikaelm12 mikaelm12 Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if there's multiple json objects prior to the \u001e delimiter.

For the handshake, the parsing logic returns as soon as the end of the json object is found. So the paylod
"{\"protocol\":\"json\",\"version\":1}{\"protocol\":\"wrong\",\"version\":99}\u001e" would result in a Handshake request message with json and version 1.

[InlineData("{\"protocol\":\"dummy\",\"version\":1}{\"protocol\":\"wrong\",\"version\":99}\u001e", "dummy", 1)]
[InlineData("{\"protocol\":\"\\u0064ummy\",\"version\":1}\u001e", "dummy", 1)]
[InlineData("{\"\\u0070rotoco\\u006c\":\"\\u0064ummy\",\"version\":1}\u001e", "dummy", 1)]
public void ParsingHandshakeRequestMessageSuccessForValidMessages(string json, string protocol, int version)
{
var message = new ReadOnlySequence<byte>(Encoding.UTF8.GetBytes(json));
Expand Down