Skip to content

Fix build race #13197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrennanConroy merged 3 commits into from
Aug 17, 2019
Merged

Fix build race #13197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df16f8
Fix build race
BrennanConroy Aug 16, 2019
915a07a
stuff
BrennanConroy Aug 16, 2019
3d3c3d4
maybe
BrennanConroy Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/SignalR/clients/ts/FunctionalTests/SignalR.Client.FunctionalTestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
<Reference Include="System.Reactive.Linq" />
</ItemGroup>

<ItemGroup Condition="'$(BuildNodeJS)' == 'true'">
<ProjectReference Include="..\signalr\signalr.npmproj" />
<ProjectReference Include="..\signalr-protocol-msgpack\signalr-protocol-msgpack.npmproj" />
</ItemGroup>
Copy link
Member

@halter73 halter73 Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.dotnet\sdk\3.0.100-preview7-012821\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(234,5): error NETSDK1004: Assets file 'F:\workspace_work\1\s\artifacts\obj\SignalR.Client.FunctionalTestApp\project.assets.json' not found. Run a NuGet package restore to generate this file.
Build failed.
Cmd.exe exited with code '1'.

Do you have any idea why nuget restore hasn't run at that point? Or why project.assets.json was deleted?


<ItemGroup>
<Folder Include="wwwroot\js\" />
</ItemGroup>
Expand Down