Fix ng test issue with Angular Template 12872 #12879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge Co-authored-by: Justin Kotalik <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: null <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Stephen Halter <[email protected]> Co-authored-by: James Newton-King <[email protected]> Co-authored-by: Mikael Mengistu <[email protected]> Co-authored-by: Pranav K <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Artak <[email protected]> Co-authored-by: Brennan <[email protected]> Co-authored-by: Steve Sanderson <[email protected]> Co-authored-by: Marcel <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Co-authored-by: Ryan Brandenburg <[email protected]> Co-authored-by: Hao Kung <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: David Fowler <[email protected]> Co-authored-by: Artak Mkrtchyan <[email protected]> Co-authored-by: Andrew Stanton-Nurse <[email protected]> Co-authored-by: Alessio Franceschelli <[email protected]> Co-authored-by: Diego Vega <[email protected]> Co-authored-by: Hisham Bin Ateya <[email protected]> Co-authored-by: N. Taylor Mullen <[email protected]> Co-authored-by: John Luo <[email protected]> Co-authored-by: huysentruitw <[email protected]>
Eilon
added
the
area-mvc
Contributor
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
What you have looks good, but let's remove this conditional so that we run the JS tests for Angular and can avoid this situation in the future.
mkArtakMSFT
added
the
tell-mode
Contributor
Author
|
@ryanbrandenburg sorry about that, baseline added |
mkArtakMSFT
removed
the
tell-mode
Contributor
|
@ryanbrandenburg please finalize the review and let's get this merged. |
ryanbrandenburg
approved these changes
Aug 28, 2019
ryanbrandenburg
added a commit
that referenced
this pull request
Sep 23, 2019
Closed
ryanbrandenburg
added a commit
that referenced
this pull request
Sep 25, 2019
ryanbrandenburg
added a commit
that referenced
this pull request
Sep 26, 2019
ryanbrandenburg
added a commit
that referenced
this pull request
Oct 1, 2019
mkArtakMSFT
pushed a commit
that referenced
this pull request
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12872