Skip to content

Ship templates in 2.1 #12540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JunTaoLuo merged 1 commit into from
Jul 25, 2019
Merged

Ship templates in 2.1 #12540

JunTaoLuo merged 1 commit into from
Jul 25, 2019

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jul 24, 2019

Addresses #12208

@JunTaoLuo JunTaoLuo requested a review from a team July 24, 2019 22:14
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jul 25, 2019

fyi @dougbu the relevant logic is at https://github.com/aspnet/AspNetCore/blob/release/2.1/build/Publish.targets#L189 and https://github.com/aspnet/AspNetCore/blob/release/2.1/build/Publish.targets#L270-L272

The difference is that the template packages will be:

  1. moved from shipoob/ to ship/ in artifacts
  2. included in the PackageToPublishToTransport items.

@JunTaoLuo JunTaoLuo merged commit f7a7c98 into release/2.1 Jul 25, 2019
@JunTaoLuo JunTaoLuo deleted the ship-templates-21 branch July 25, 2019 03:36
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JunTaoLuo @dougbu