Remove flaky mark from E2E templates tests #12450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-mvc
ryanbrandenburg
approved these changes
Jul 22, 2019
Contributor
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
I'm of the opinion that Templating tests should only be marked Flaky in the most dire of circumstances because they're often broken by upstream changes, and these tests are literally the only place where that would be caught.
for these changes, but there seems to be a problem with the BlazorServer tests.
Member
Author
|
Yes there is, I'm fixing it. |
javiercn
force-pushed
the
javiercn/unflaky-templates-tests
branch
from
e2edbd6 to
6317ae8
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues mentioned in there were closed without removing the attribute.
Good judgement needs to be used when marking tests as flaky, as currently all the templates tests for blazor server-side were marked as flaky, leaving us without real coverage for the thing that we ship to our customers.