Skip to content

Update default project names #12431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JunTaoLuo merged 3 commits into from
Jul 25, 2019
Merged

Update default project names #12431

JunTaoLuo merged 3 commits into from
Jul 25, 2019

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jul 22, 2019

Addresses #11820.

WIP testing.

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 22, 2019
JamesNK
JamesNK approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gRPC change 👍

@JunTaoLuo JunTaoLuo marked this pull request as ready for review July 24, 2019 00:19
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jul 24, 2019

I'll test this out in VS tomorrow.

@ryanbrandenburg
Copy link
Contributor

ryanbrandenburg commented Jul 24, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=276829

@aspnet-hello
Copy link

aspnet-hello commented Jul 24, 2019

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2617

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Jul 25, 2019

@danroth27 I remember you were making plans about template names. Are these the template names you wanted?

danroth27
danroth27 approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danroth27
Copy link
Member

danroth27 commented Jul 25, 2019

@SteveSandersonMS This PR will clean up the default project names generated by the templates in VS. Changing the template names I believe was already done.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jul 25, 2019

Turns out we can't test this without VS work so I'm merging as is.

@JunTaoLuo JunTaoLuo merged commit 2884ef6 into master Jul 25, 2019
@ghost ghost deleted the johluo/template-project-renames branch July 25, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@danroth27 danroth27 danroth27 approved these changes

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

+1 more reviewer

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JunTaoLuo @ryanbrandenburg @aspnet-hello @SteveSandersonMS @danroth27 @JamesNK @Pilchie