Skip to content

Fix ConcurrentPipeWriterTests #12383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halter73 merged 1 commit into from
Jul 24, 2019
Merged

Fix ConcurrentPipeWriterTests #12383

halter73 merged 1 commit into from
Jul 24, 2019

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Jul 19, 2019

@halter73 halter73 requested a review from jkotalik July 19, 2019 21:50
@halter73
Copy link
Member Author

halter73 commented Jul 19, 2019

This is easier to review with whitespace in diffs disabled.

@analogrelay analogrelay added this to the 3.0.0-preview8 milestone Jul 23, 2019
@analogrelay analogrelay added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 23, 2019
@halter73 halter73 merged commit 34903da into master Jul 24, 2019
@halter73 halter73 deleted the halter73/2839 branch July 24, 2019 21:51
@jkotalik
Copy link
Contributor

jkotalik commented Aug 26, 2019

This fix didn't get into release/3.0. We should consider porting there.

@halter73 halter73 mentioned this pull request Aug 29, 2019
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

1 more reviewer

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

3.0.0-preview8

Development

Successfully merging this pull request may close these issues.

6 participants

@halter73 @jkotalik @analogrelay @Pilchie @amcasey