Skip to content

Unified response body features #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tratcher merged 28 commits into from
Jul 25, 2019
Merged

Unified response body features #12328

Tratcher merged 28 commits into from
Jul 25, 2019

Conversation

@Tratcher
Copy link
Member

@Tratcher Tratcher commented Jul 18, 2019 •
edited
Loading

#11305 Consolidates the response body features

Obsolete
IHttpResponseFeature.Body
IHttpBufferingFeature

Deleted (new in 3.0)
IHttpResponseBodyPipeFeature
IHttpResponseStartFeature
IHttpResponseCompleteFeature

@Tratcher Tratcher added this to the 3.0.0-preview8 milestone Jul 18, 2019
@Tratcher Tratcher self-assigned this Jul 18, 2019
@jkotalik
Copy link
Contributor

jkotalik commented Jul 18, 2019

PR to fix is here: dotnet/corefx#39610

davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
halter73
halter73 reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
davidfowl
davidfowl reviewed Jul 19, 2019
View reviewed changes
jkotalik
jkotalik reviewed Jul 19, 2019
View reviewed changes
jkotalik
jkotalik reviewed Jul 19, 2019
View reviewed changes
@jkotalik
Copy link
Contributor

jkotalik commented Jul 19, 2019

So far this looks great. It's significantly easier to replace the body now than it was before.

@halter73

This comment has been minimized.

Sign in to view
jkotalik
jkotalik reviewed Jul 25, 2019
View reviewed changes
jkotalik
jkotalik reviewed Jul 25, 2019
View reviewed changes
jkotalik
jkotalik reviewed Jul 25, 2019
View reviewed changes
jkotalik
jkotalik reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@jkotalik jkotalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not concerned with anything in this PR.

halter73
halter73 reviewed Jul 25, 2019
View reviewed changes
@Tratcher Tratcher marked this pull request as ready for review July 25, 2019 20:31
@jkotalik jkotalik added breaking-change This issue / pr will introduce a breaking change, when resolved / merged. zesty 🍞 labels Jul 25, 2019
@Tratcher Tratcher merged commit 0806609 into master Jul 25, 2019
@Tratcher Tratcher deleted the tratcher/unificationday branch July 25, 2019 23:27
This was referenced Jul 26, 2019
Open
Closed
Open
@JamesNK JamesNK mentioned this pull request Dec 17, 2019
Closed
@JamesNK JamesNK mentioned this pull request Feb 1, 2020
Closed
@nibblesnbits nibblesnbits mentioned this pull request Jul 21, 2021
Closed
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl left review comments

@halter73 halter73 halter73 approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

+1 more reviewer

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tratcher Tratcher

Labels

api-suggestion Early API idea and discussion, it is NOT ready for implementation area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions breaking-change This issue / pr will introduce a breaking change, when resolved / merged. tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

3.0.0-preview8

Development

Successfully merging this pull request may close these issues.

7 participants

@Tratcher @jkotalik @halter73 @davidfowl @analogrelay @amcasey