-
Notifications
You must be signed in to change notification settings - Fork 10.9k
Generate VS nuget package for 2.1 #11616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2d163cf
Build packages for VS insertion of 2.1 shared framework
jkotalik 5d1177c
Update script
jkotalik 4f1acae
Nits
jkotalik cb0ed48
remove en
jkotalik b56345d
Keep en and remove slash
jkotalik 174cc2d
another nit
jkotalik 017687a
nit
jkotalik 8dfc4c6
Update SharedFramework.wixproj
jkotalik 74d3cf6
Update src/Installers/Windows/SharedFramework/SharedFrameworkPackage.…
jkotalik 2409bef
Update src/Installers/Windows/SharedFramework/SharedFrameworkPackage.…
jkotalik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Copyright (c) .NET Foundation and contributors. All rights reserved. | ||
| # Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| param( | ||
| [Parameter(Mandatory=$true)][string]$Name, | ||
| [Parameter(Mandatory=$true)][string]$MsiPath, | ||
| [Parameter(Mandatory=$false)][string]$CabPath, | ||
| [Parameter(Mandatory=$true)][string]$NuspecFile, | ||
| [Parameter(Mandatory=$true)][string]$OutputDirectory, | ||
| [Parameter(Mandatory=$true)][string]$Architecture, | ||
| [Parameter(Mandatory=$true)][string]$PackageVersion, | ||
| [Parameter(Mandatory=$true)][string]$RepoRoot, | ||
| [Parameter(Mandatory=$true)][string]$MajorVersion, | ||
| [Parameter(Mandatory=$true)][string]$MinorVersion | ||
| ) | ||
|
|
||
| $NuGetDir = Join-Path $RepoRoot "obj\Tools\nuget\$Name\$Architecture" | ||
| $NuGetExe = Join-Path $NuGetDir "nuget.exe" | ||
|
|
||
| if (-not (Test-Path $NuGetDir)) { | ||
| New-Item -ItemType Directory -Force -Path $NuGetDir | Out-Null | ||
| } | ||
|
|
||
| if (-not (Test-Path $NuGetExe)) { | ||
| # Using 3.5.0 to workaround https://github.com/NuGet/Home/issues/5016 | ||
| Write-Output "Downloading nuget.exe to $NuGetExe" | ||
| wget https://dist.nuget.org/win-x86-commandline/v3.5.0/nuget.exe -OutFile $NuGetExe | ||
| } | ||
|
|
||
| & $NuGetExe pack $NuspecFile -Version $PackageVersion -OutputDirectory $OutputDirectory -NoDefaultExcludes -NoPackageAnalysis -Properties ASPNETCORE_RUNTIME_MSI=$MsiPath`;ASPNETCORE_CAB_FILE=$CabPath`;ARCH=$Architecture`;MAJOR=$MajorVersion`;MINOR=$MinorVersion`; | ||
| Exit $LastExitCode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/Installers/Windows/SharedFramework/SharedFrameworkPackage.nuspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd"> | ||
| <metadata> | ||
| <id> VS.Redist.Common.AspNetCore.SharedFramework.$ARCH$.$MAJOR$.$MINOR$</id> | ||
|
jkotalik marked this conversation as resolved.
Outdated
|
||
| <version>1.0.0</version> | ||
| <title> VS.Redist.Common.AspNetCore.SharedFramework.$ARCH$.$MAJOR$.$MINOR$</title> | ||
|
jkotalik marked this conversation as resolved.
Outdated
|
||
| <authors>Microsoft</authors> | ||
| <owners>Microsoft</owners> | ||
| <licenseUrl>https://www.microsoft.com/net/dotnet_library_license.htm</licenseUrl> | ||
| <projectUrl>https://github.com/aspnet/aspnetcore</projectUrl> | ||
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | ||
| <description>$MAJOR$.$MINOR$ ASP.NET Core TargetingPack ($ARCH$) Windows Installer MSI as a .nupkg for internal Visual Studio build consumption</description> | ||
| <copyright>© Microsoft Corporation. All rights reserved.</copyright> | ||
| </metadata> | ||
| <files> | ||
| <file src="$ASPNETCORE_RUNTIME_MSI$" /> | ||
| <file src="$ASPNETCORE_CAB_FILE$" /> | ||
| </files> | ||
| </package> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.