Skip to content

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Jun 10, 2019

  • Replaces the embedded file support inside identity with support for the new static web assets feature.
  • Removes the need to specify the bootstrap framework at runtime.
  • Removes the need to embed static assets into the assembly.
  • Removes the need to hijack the static file options to plug in the static assets.
  • Copies only the assets for the selected version to the output folder on publish.

@analogrelay analogrelay added the area-identity Includes: Identity and providers label Jun 10, 2019
@javiercn javiercn marked this pull request as ready for review June 11, 2019 15:42
@javiercn javiercn requested review from HaoK and pranavkm June 11, 2019 15:42
@javiercn javiercn changed the title [Identity][WIP] Move to use static web assets support. [Identity] Move to use static web assets support. Jun 11, 2019
@javiercn javiercn force-pushed the javiercn/identity-static-web-assets branch from f1240f1 to 897d6a8 Compare June 11, 2019 15:52
@javiercn javiercn force-pushed the javiercn/identity-static-web-assets branch from 897d6a8 to a5ae8a7 Compare July 20, 2019 18:29
@javiercn javiercn force-pushed the javiercn/identity-static-web-assets branch from a5ae8a7 to 8f1c3fe Compare July 23, 2019 14:55
@javiercn javiercn force-pushed the javiercn/identity-static-web-assets branch from fd411f2 to 9454f64 Compare July 24, 2019 15:37
@javiercn javiercn force-pushed the javiercn/identity-static-web-assets branch from 9454f64 to 32939e4 Compare July 24, 2019 15:38
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProjectTemplates parts of this seem fine, I'll leave reviewing the IdentityUI stuff to someone with more context.

@mkArtakMSFT mkArtakMSFT added the tell-mode Indicates a PR which is being merged during tell-mode label Jul 24, 2019
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the UIFramework runtime options is nice

@javiercn javiercn force-pushed the javiercn/identity-static-web-assets branch from 14e6908 to 901d238 Compare July 25, 2019 03:11
@javiercn javiercn merged commit 143c101 into master Jul 25, 2019
@javiercn javiercn deleted the javiercn/identity-static-web-assets branch July 25, 2019 15:34
@javiercn javiercn added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-identity Includes: Identity and providers breaking-change This issue / pr will introduce a breaking change, when resolved / merged. tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants