-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Open
Labels
area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkbugThis issue describes a behavior which is not expected - a bug.This issue describes a behavior which is not expected - a bug.
Milestone
Description
Is there an existing issue for this?
- I have searched the existing issues
Describe the bug
Benchmarks written with benchmarkdotnet are validated on build:
aspnetcore/eng/targets/CSharp.Common.targets
Lines 133 to 142 in f0af112
| <Target Name="ValidateBenchmarks" BeforeTargets="Test" Condition="'$(IsMicrobenchmarksProject)' == 'true' AND '$(SkipMicrobenchmarksValidation)' != 'true'"> | |
| <Message Text="%0ARunning benchmark validation for:%0A$(MSBuildProjectName)%0A" | |
| Importance="High" /> | |
| <MSBuild Projects="$(MSBuildProjectFullPath)" Targets="GetTargetPath"> | |
| <Output TaskParameter="TargetOutputs" PropertyName="ExecPath" /> | |
| </MSBuild> | |
| <Exec Command="dotnet $(ExecPath) -f * --validate-fast" IgnoreStandardErrorWarningFormat="true" StandardOutputImportance="low" /> | |
| </Target> |
It appears that failures are only correctly reported on Windows. This behavior was noticed when I added a benchmark that is only valid for Windows, but tests all passed.
For example, I added an exception to a benchmark's setup here - #46491 - and only Windows tests failed:
I can see in the logs that they are being detected and run on other OS, but no error reported:
Expected Behavior
Validation reports problems and the build fails on Linux and macOS.
Steps To Reproduce
Exceptions (if any)
No response
.NET Version
No response
Anything else?
No response
Metadata
Metadata
Assignees
Labels
area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkbugThis issue describes a behavior which is not expected - a bug.This issue describes a behavior which is not expected - a bug.

