ContentRootPath normalization / DataProtection Discriminator

[HaoK]

aspnetcore/src/DataProtection/DataProtection/src/Internal/HostingApplicationDiscriminator.cs

Line 23 in a450cb6

public string? Discriminator => _hosting?.ContentRootPath;

Changes in trailing / no slash are what causes cookies to break between versions

we need to figure out where/how to normalize things

cc @blowdart

[blowdart]

We're going to break someone no matter what we do sigh Didn't we break from 3.1 and 5 to 6?

[HaoK]

Well prior to 6, there was no trailing slash in the content root.
In 6 (for minimal style apps), there's a trailing slash
Now in 7, its back to no trailing slash, so non minimal apps will behave the same, its just minimal apps from 6 won't be able to read their cookies in 7

So for non minimal apps, i think there's no issue in any versions, as content root never had a slash.

Its only minimal style hosting apps that are seeing things change

[blowdart]

Oh well if it's "just" minimal apps, then minimal apps should change to be the same as everything that came before (and a quirk ported back to 6)

[HaoK]

I believe the issue is at the hosting layer (minimal vs non minimal use a different hosting environment I think?), which is why we have to pick between changing the hosting behavior (to enforce no trailing slashes), or add some logic to our discriminator which now will strip trailing slashes from the content root.

[HaoK]

So @blowdart are we okay just normalizing the default data protection application discriminator to always trim trailing slashes? I think that will get us out of this business of content root changes breaking data protection

[HaoK]

Alternatively we could clean it up here: which seems less ideal

aspnetcore/src/DataProtection/DataProtection/src/DataProtectionUtilityExtensions.cs

Line 45 in a450cb6

discriminator = discriminator?.Trim();

[blowdart]

Works for me. And obviously documentation in release notes