Cloning at tag v3.1.9 has incorrect versions in global.json

[IanKemp]

sdk:version and tools:dotnet are set to 3.1.107 which is the SDK for v3.1.7. Updating these fields to 3.1.109 ensures the correct SDK version is installed.

tools:runtimes:dotnet/x64 is set to $(MicrosoftNETCoreAppInternalPackageVersion) which causes dotnet-install to download https://dotnetcli.azureedge.net/dotnet/Runtime/3.1.8-servicing.20420.1/dotnet-runtime-3.1.8-servicing.20420.1-win-x64.zip which is incorrect. Forcing this value to 3.1.9 correctly uses/downloads the v3.1.9 runtime. I have no idea what $MicrosoftNETCoreAppInternalPackageVersion is or where it is set, and honestly I couldn't be bothered.

tools:vs:version is set to 16.3, should be 16.4.

If you're going to provide build scripts, make sure they're correct for the version being built, or don't supply them at all.

[IanKemp]

Seems that 3.1.8 is hardcoded somewhere, with the result that all artifacts get versioned and built as such.

Also getting

Attempting download 'https://dotnetcli.blob.core.windows.net/dotnet/Runtime/3.1.8-servicing.20420.1/dotnet-runtime-3.
  1.8-win-x64.zip' to 'C:\aspnetcore\artifacts\obj\Microsoft.AspNetCore.App.Runtime\dotnet-runtime-3.1.8-win-x64.zip'

Seems like this $(MicrosoftNETCoreAppInternalPackageVersion) variable is getting set to 3.1.8-servicing.20420.1 somehow, based on what I'm seeing in Microsoft.AspNetCore.App.Runtime.csproj.

[IanKemp]

Ahhh, ok, it's eng/Version.props which is still referencing 3.1.8 everywhere. That needs to be updated to whatever the correct versions of 3.1.9 are too.

Seems like cf7c111 fixed the AspNetCorePatchVersion at least. Then b5bc2cb fixed the packages. I arbitrarily chose to checkout 6aa39db and I am now getting 3.1.9 versions as expected. However, global.json remains at the incorrect versions I noted in my first comment.

Would really appreciate if someone from the team could tell me what commit I should be using. I just wanted to build locally so I could debug through what ParameterBinder is doing - I didn't expect to have to spend hours grepping through this repo to figure out that whoever at Microsoft who is responsible for ensuring versions are kept updated, is not doing their job.

[IanKemp]

The tl;dr appears to be that whoever tagged v3.1.9 didn't update the build scripts to the correct version beforehand. That tag should be deleted and the repo re-tagged as v3.1.9 at the appropriate commit - whatever that may be.

[wtgodbe]

Apologies, looks like you're right - the correct commit is d12868d. I've just updated it - https://github.com/dotnet/aspnetcore/releases/tag/v3.1.9

@rbhanda it looks like the drop for 3.1.9 had multiple Aspnetcore versions in the manifest, and the automation chose the older one. I'll try to make sure that the drops are clean in the future, but it'd also be good if the tagging automation defaulted to choosing the newest rather than the oldest