Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor WASM apps should default new runtime config options to link out unnecessary code #23716

Closed
eerhardt opened this issue Jul 6, 2020 · 0 comments · Fixed by #23932
Closed

Blazor WASM apps should default new runtime config options to link out unnecessary code #23716

eerhardt opened this issue Jul 6, 2020 · 0 comments · Fixed by #23932
Labels
area-blazor Includes: Blazor, Razor Components
Milestone
5.0.0-preview8

Comments

@eerhardt
Copy link
Member

eerhardt commented Jul 6, 2020 •
edited by marek-safar
Loading

In order to support smaller applications, the following feature switches are being added to dotnet/runtime:

See the SDK support at dotnet/sdk#12362.

The Blazor SDK should default these new properties in order to get as small of app as possible.

<EventSourceSupport Condition="'$(EventSourceSupport)' == ''">false</EventSourceSupport>
<UseSystemResourceKeys Condition="'$(UseSystemResourceKeys)' == ''">true</UseSystemResourceKeys>
<EnableUnsafeUTF7Encoding Condition="'$(EnableUnsafeUTF7Encoding)' == ''">false</EnableUnsafeUTF7Encoding>

<RuntimeHostConfigurationOption Include="System.Net.Http.EnableActivityPropagation"
                                Value="false"
                                Trim="true" />

Note the Debugger.IsSupported is not implemented yet.

@pranavkm @SteveSandersonMS
@pranavkm pranavkm added the area-blazor Includes: Blazor, Razor Components label Jul 7, 2020
@pranavkm pranavkm added this to the 5.0.0-preview8 milestone Jul 7, 2020
eerhardt added a commit to eerhardt/aspnetcore that referenced this issue Jul 14, 2020
@eerhardt
Default new runtime feature switches
262692b 
These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix dotnet#23716
@eerhardt eerhardt mentioned this issue Jul 14, 2020
Merged
@ghost ghost closed this as completed in #23932 Jul 16, 2020
ghost pushed a commit that referenced this issue Jul 16, 2020
@eerhardt
Default new runtime feature switches (#23932)
7b42cf1 
* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix #23716

* PR feedback
eerhardt added a commit to eerhardt/aspnetcore that referenced this issue Jul 16, 2020
@eerhardt
Default new runtime feature switches (dotnet#23932)
3f96db5 
* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix dotnet#23716

* PR feedback
@eerhardt eerhardt mentioned this issue Jul 16, 2020
Merged
mkArtakMSFT pushed a commit that referenced this issue Jul 16, 2020
@eerhardt
Default new runtime feature switches (#23932) (#23987)
427bfc8 
* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix #23716

* PR feedback
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2020
dougbu pushed a commit to dougbu/razor-compiler that referenced this issue Nov 17, 2021
@eerhardt
Default new runtime feature switches (dotnet/aspnetcore#23932)
f83136d 
* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix dotnet/aspnetcore#23716

* PR feedback

Commit migrated from dotnet/aspnetcore@7b42cf1275b2
dougbu pushed a commit to dougbu/razor-compiler that referenced this issue Nov 17, 2021
@eerhardt
Default new runtime feature switches (dotnet/aspnetcore#23932) (dotne…
786ffed 
…t/aspnetcore#23987)

* Default new runtime feature switches

These new feature switches have been added to the runtime to make applications smaller. Setting reasonable defaults to Blazor wasm projects.

Fix dotnet/aspnetcore#23716

* PR feedback

Commit migrated from dotnet/aspnetcore@427bfc8d6b05
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
5.0.0-preview8
Development

Successfully merging a pull request may close this issue.

Default new runtime feature switches eerhardt/aspnetcore
2 participants
@pranavkm @eerhardt