Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Streaming API support to MVC #11558

Closed
1 task
Tracked by #27883
pranavkm opened this issue Jun 25, 2019 · 6 comments
Closed
1 task
Tracked by #27883

Add Streaming API support to MVC #11558

pranavkm opened this issue Jun 25, 2019 · 6 comments
Assignees
@pranavkm
Labels
affected-medium This issue impacts approximately half of our customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-mvc-formatting Priority:1 Work that is critical for the release, but we could probably ship without severity-major This label is used by an internal tool Theme: meeting developer expectations User Story A single user-facing feature. Can be grouped under an epic.
Milestone
6.0-preview4

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Jun 25, 2019 •
edited by mkArtakMSFT
Loading

See previous discussions here - #4833

This depends on:
@pranavkm pranavkm mentioned this issue Jun 25, 2019
Closed
@pranavkm pranavkm added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Jun 25, 2019
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 25, 2019
@mkArtakMSFT
Copy link
Member

It's not clear what's being asked here. Closing, until we have a concrete proposal here.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@javiercn javiercn mentioned this issue Jun 22, 2020
Closed
@expcat expcat mentioned this issue Oct 6, 2020
Closed
@dotnet dotnet unlocked this conversation Oct 6, 2020
@mkArtakMSFT mkArtakMSFT reopened this Oct 6, 2020
@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Oct 6, 2020
@ghost
Copy link

ghost commented Oct 6, 2020

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@SteveSandersonMS SteveSandersonMS added affected-medium This issue impacts approximately half of our customers severity-major This label is used by an internal tool labels Nov 6, 2020 — with ASP.NET Core Issue Ranking
@mkArtakMSFT mkArtakMSFT mentioned this issue Nov 16, 2020
Closed
27 tasks
@ghost
Copy link

ghost commented Dec 7, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@mkArtakMSFT mkArtakMSFT mentioned this issue Dec 8, 2020
Closed
11 tasks
@mkArtakMSFT mkArtakMSFT added the User Story A single user-facing feature. Can be grouped under an epic. label Dec 8, 2020
@mkArtakMSFT
Copy link
Member

This work depends on dotnet/runtime#1570

@bradygaster
Copy link
Member

Can confirm with @mkArtakMSFT this is in the right spot. Also can confirm this and dotnet/runtime#1570 would be very-very nice-to-have items. Anything that makes it easier [more elegant, discoverable, yada^2] is a good thing IMO.

@mkArtakMSFT mkArtakMSFT added the Priority:1 Work that is critical for the release, but we could probably ship without label Jan 8, 2021
@mkArtakMSFT
Copy link
Member

We're still waiting for the above referenced issue from the dotnet/runtime repo to be delivered to be able to get to this. Synced up with @ericstj and that is going to land no sooner than 6.0-preview4, so we're still blocked here.

@mkArtakMSFT mkArtakMSFT added the blocked The work on this issue is blocked due to some dependency label Mar 17, 2021
@mkArtakMSFT mkArtakMSFT removed the blocked The work on this issue is blocked due to some dependency label Apr 13, 2021
@pranavkm pranavkm removed this from the Next sprint planning milestone Apr 19, 2021
@pranavkm pranavkm added this to the 6.0-preview4 milestone Apr 19, 2021
@pranavkm pranavkm mentioned this issue Apr 19, 2021
Merged
10 tasks
mkArtakMSFT pushed a commit that referenced this issue Apr 19, 2021
@pranavkm
Use System.Text.Json's IAsyncEnumerable support (#31894)
af70a2b 
## Description

System.Text.Json recently added support for streaming IAsyncEnumerable types based on an ask from the ASP.NET Core team. This PR enables MVC to leverage this feature.

## Customer Impact
Using IAsyncEnumerable with System.Text.Json will result in data to be streamed rather than buffered and serialized.

## Regression?
- [ ] Yes
- [x] No

[If yes, specify the version the behavior has regressed from]

## Risk
- [ ] High
- [ ] Medium
- [x] Low

[Justify the selection above]
The feature has been well-tested in the runtime. This is simply removing additional buffering that was previously performed by MVC before invoking the serializer.

## Verification
- [x] Manual (required)
- [x] Automated

## Packaging changes reviewed?
- [ ] Yes
- [x] No
- [ ] N/A


Addresses #11558 #23203
@ghost ghost added Done This issue has been fixed and removed Working labels Apr 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
affected-medium This issue impacts approximately half of our customers area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-mvc-formatting Priority:1 Work that is critical for the release, but we could probably ship without severity-major This label is used by an internal tool Theme: meeting developer expectations User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Milestone
6.0-preview4
Development

No branches or pull requests
6 participants
@pranavkm @Eilon @SteveSandersonMS @javiercn @mkArtakMSFT @bradygaster