Fix SqlServer PowerShell module version to avoid breaking changes in 22.4.5.1 #9939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sebastienros <[email protected]>
Copilot
AI
changed the title
[WIP] Pin SqlServer PowerShell module version in provisioning script to workaround 22.4.5.1 issue (#9926)
Fix SqlServer PowerShell module version to avoid breaking changes in 22.4.5.1
Jun 18, 2025
Copilot finished work on behalf of
sebastienros
June 18, 2025 18:27
Member
|
@copilot the correct version to use is 22.3.0 |
Co-authored-by: sebastienros <[email protected]>
Contributor
Author
Updated all files to use version 22.3.0 as requested. Commit b75c670 Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Pins the SqlServer PowerShell module to a specific known-good version across all provisioning scripts to prevent breaking changes from version 22.4.5.1.
- Updated the C# provisioning template to install SqlServer module at a fixed version.
- Updated six deployment script modules (Bicep & CDK) to use the same pinned version.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs | Pin Install-Module to a specific RequiredVersion |
| playground/cdk/CdkSample.AppHost/sql-roles.module.bicep | Pin SqlServer module version in scriptContent |
| playground/bicep/BicepSample.AppHost/sql-roles.module.bicep | Pin SqlServer module version in scriptContent |
| playground/SqlServerScript/AppHost1/api2-roles-mysqlserver.module.bicep | Pin SqlServer module version in scriptContent |
| playground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicep | Pin SqlServer module version in scriptContent |
| playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep | Pin SqlServer module version in scriptContent |
| playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep | Pin SqlServer module version in scriptContent |
sebastienros
approved these changes
Jun 18, 2025
Member
|
Verified successfully. Tested before and after the fix. |
Member
|
/backport to release/9.3 |
Contributor
|
Started backporting to release/9.3: https://github.com/dotnet/aspire/actions/runs/15746264622 |
Contributor
|
@sebastienros backporting to "release/9.3" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Creating an empty commit: Initial plan for issue
Applying: Fix SqlServer PowerShell module version to avoid breaking changes
Using index info to reconstruct a base tree...
M playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep
M playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep
M playground/bicep/BicepSample.AppHost/sql-roles.module.bicep
M playground/cdk/CdkSample.AppHost/sql-roles.module.bicep
M src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs
Auto-merging playground/cdk/CdkSample.AppHost/sql-roles.module.bicep
CONFLICT (content): Merge conflict in playground/cdk/CdkSample.AppHost/sql-roles.module.bicep
Auto-merging playground/bicep/BicepSample.AppHost/sql-roles.module.bicep
CONFLICT (content): Merge conflict in playground/bicep/BicepSample.AppHost/sql-roles.module.bicep
Auto-merging playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep
Auto-merging playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Fix SqlServer PowerShell module version to avoid breaking changes
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
davidfowl
approved these changes
Jun 19, 2025
captainsafia
pushed a commit
that referenced
this pull request
Jun 20, 2025
…22.4.5.1 (#9939) * Initial plan for issue * Fix SqlServer PowerShell module version to avoid breaking changes Co-authored-by: sebastienros <[email protected]> * Update SqlServer PowerShell module version to 22.3.0 as requested Co-authored-by: sebastienros <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: sebastienros <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates all provisioning scripts to pin the SqlServer PowerShell module to version 22.3.0 to avoid breaking changes introduced in version 22.4.5.1.
Problem
The current provisioning scripts use:
This installs the latest version of the SqlServer module, which can include breaking changes. Version 22.4.5.1 introduced breaking changes that affect the deployment scripts.
Solution
Changed all instances to specify the last known working version:
Files Changed
src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs- Updated the PowerShell script templateplayground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicepplayground/SqlServerScript/AppHost1/api2-roles-mysqlserver.module.bicepplayground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicepplayground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicepplayground/bicep/BicepSample.AppHost/sql-roles.module.bicepplayground/cdk/CdkSample.AppHost/sql-roles.module.bicepTesting
az bicep buildFixes #9926
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.msbicep build playground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicep --stdout(dns block)bicep build playground/bicep/BicepSample.AppHost/sql-roles.module.bicep --stdout(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.