Skip to content

Conversation

danmoseley
Copy link
Member

Fix these issues, and pin markdownlint so new rules don't appear out of the blue again.

Fix these issues, and pin markdownlint so new rules don't appear out of the blue again.
@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 22:46
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 27, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes markdown lint issues and standardizes documentation link formatting while pinning the markdownlint CLI version to avoid unexpected future changes.

  • Updated the wording and link formatting in Aspire components and dashboard READMEs.
  • Pinned markdownlint-cli to version 0.45.0 in the GitHub workflow.
  • Standardized sample repository link formatting in the root README.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/Components/Aspire_Components_Progress.md Revised README sample link text for improved clarity
src/Aspire.Dashboard/README.md Enhanced telemetry section link formatting
README.md Standardized sample link formatting
.github/workflows/markdownlint.yml Pinned the markdownlint-cli version to prevent unexpected rules

@sebastienros
Copy link
Member

The PR mentions 9.3, is this going first to main or was the target branch a typo?

@danmoseley danmoseley added area-engineering-systems infrastructure helix infra engineering repo stuff and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 27, 2025
@danmoseley
Copy link
Member Author

target branch is a misfire. I'll fix.

@danmoseley danmoseley changed the base branch from main to release/9.3 May 27, 2025 22:58
@danmoseley
Copy link
Member Author

@sebastienros fixed

@danmoseley danmoseley changed the title fix markdown lint in release/9.3 [release/9.3] fix markdown lint in release/9.3 May 28, 2025
@wtgodbe wtgodbe merged commit dcbd3d9 into dotnet:release/9.3 May 28, 2025
252 of 253 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-engineering-systems infrastructure helix infra engineering repo stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants