Skip to content

Conversation

Copy link
Contributor

Copilot AI commented May 21, 2025

This PR removes the --prerelease switch from the aspire new and aspire add CLI commands while defaulting the prerelease parameter to true for internal API calls.

Changes

  • Removed the --prerelease option from NewCommand
  • Removed the --prerelease option from AddCommand
  • Updated NuGetPackageCache and IDotNetCliRunner interfaces to default prerelease to true in method signatures
  • Updated implementations to use the new default value
  • Made the options parameter nullable in SearchPackagesAsync with appropriate handling
  • Updated test fixtures to reflect these changes

This approach simplifies the CLI interface while ensuring that prerelease packages are included by default in searches, with the option to change this behavior in the future through the internal API if needed.

Fixes #9446.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.fwupd.org
    • Triggering command: /usr/bin/fwupdmgr refresh (dns block)
  • dnceng.pkgs.visualstudio.com
    • Triggering command: /home/REDACTED/work/aspire/aspire/.dotnet/dotnet test tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj (dns block)
  • pkgs.dev.azure.com
    • Triggering command: /home/REDACTED/work/aspire/aspire/.dotnet/dotnet test tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Remove --prerelease switches from the aspire new and aspire add CLI commands Remove --prerelease switches from aspire CLI commands May 21, 2025
Copilot AI requested a review from mitchdenny May 21, 2025 10:16
@mitchdenny mitchdenny marked this pull request as ready for review May 22, 2025 01:43
Copy link
Contributor Author

Copilot AI commented May 22, 2025

@davidfowl Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 622100e3-f10d-4c29-bc35-a08e882115b7

Sorry for the inconvenience!

@davidfowl davidfowl merged commit 15e7f18 into main May 22, 2025
254 checks passed
@davidfowl davidfowl deleted the copilot/fix-9446 branch May 22, 2025 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove --prerelease switches from the aspire new and aspire add CLI commands

3 participants