Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented May 20, 2025

Description

  • Remove FluentSelect hack that has been fixed in library
  • Use new try get methods with icons to avoid errors

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings May 20, 2025 08:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates FluentUI dependencies to 4.11.9, refactors icon resolution to use the new TryGetInstance pattern, and removes the temporary FixedFluentCombobox workaround in favor of the built-in component.

  • Bump Microsoft.FluentUI.AspNetCore.Components and .Icons to 4.11.9
  • Replace try/catch in IconResolver with IconInfo.TryGetInstance
  • Delete FixedFluentCombobox component and switch references to FluentCombobox

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
src/Aspire.Dashboard/Model/IconResolver.cs Refactored to use TryGetInstance instead of catch‐all logic
src/Aspire.Dashboard/Components/Dialogs/FilterDialog.razor Switched from FixedFluentCombobox to built-in FluentCombobox
src/Aspire.Dashboard/Components/Controls/FixedFluentCombobox.* Removed temporary workaround component files
Directory.Packages.props Bumped FluentUI package versions to 4.11.9
Comments suppressed due to low confidence (2)

src/Aspire.Dashboard/Model/IconResolver.cs:45

  • [nitpick] The method takes both IconKey key (which includes DesiredIconSize) and a separate size parameter. Consider removing the redundant size argument and using key.DesiredIconSize to reduce duplication and potential mismatch.
private static bool TryGetIcon(IconKey key, IconSize size, [NotNullWhen(true)] out CustomIcon? icon)

src/Aspire.Dashboard/Model/IconResolver.cs:54

  • Add a unit test for the failure path when TryGetInstance returns false to ensure coverage for missing icons and proper null handling.
return iconInfo.TryGetInstance(out icon);

@danmoseley danmoseley merged commit e0e5da0 into main May 20, 2025
254 checks passed
@danmoseley danmoseley deleted the jamesnk/fluent-ui-update-4.11.9 branch May 20, 2025 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants