Skip to content

Ensure all grid columns have tooltips #9401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
+10 −0
Merged

Ensure all grid columns have tooltips #9401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Components/Controls/Grid/AspirePropertyColumn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ public class AspirePropertyColumn<TGridItem, TProp> : PropertyColumn<TGridItem,
[Parameter]
public string? ColumnId { get; set; }

protected override void OnInitialized()
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both AspireTemplateColumn and AspirePropertyColumn set Tooltip = true in their OnInitialized methods. Consider refactoring this shared behavior into a common base class to reduce duplicate code and ease future maintenance.

Copilot uses AI. Check for mistakes.
{
Tooltip = true;
}

protected override bool ShouldRender()
{
if (ColumnManager is not null && ColumnId is not null && !ColumnManager.IsColumnVisible(ColumnId))
Expand Down
5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/Components/Controls/Grid/AspireTemplateColumn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ public class AspireTemplateColumn<TGridItem> : TemplateColumn<TGridItem>, IAspir
[Parameter]
public string? ColumnId { get; set; }

protected override void OnInitialized()
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both AspireTemplateColumn and AspirePropertyColumn set Tooltip = true in their OnInitialized methods. Consider refactoring this shared behavior into a common base class to reduce duplicate code and ease future maintenance.

Copilot uses AI. Check for mistakes.
{
Tooltip = true;
}

protected override bool ShouldRender()
{
if (ColumnManager is not null && ColumnId is not null && !ColumnManager.IsColumnVisible(ColumnId))
Expand Down