Skip to content

Prevent text overflow in resource action URLs #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Prevent text overflow in resource action URLs #9314

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba41dc1
Prevent text overflow in resource action URLs
adamint May 14, 2025
9c8cbda
Add url and command with long display names
adamint May 19, 2025
1cfd16d
Apply width: 100% and ellipsis overflow to all menu items. Explicitly…
adamint May 19, 2025
ca6ef3e
Merge branch 'main' into dev/adamint/fix-url-overflow-resource-actions
adamint May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Aspire.Dashboard/Model/ResourceMenuItems.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public static void AddMenuItems(
Text = url.Text,
Tooltip = url.Url,
Icon = s_linkIcon,
Class = "resource-actions-url-menuitem",
Copy link
Member

@JamesNK JamesNK May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not apply the class to all menu items at a lower level?

Or add a style to the fluent menu in AspireMenu, and that style applies to all items inside the fluent menu.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, I imagine this problem could also happen if there is a very long command name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, added to all fluent-menu-items.

AdditionalAttributes = new Dictionary<string, object>
{
["data-openbutton"] = "true",
Expand Down
5 changes: 5 additions & 0 deletions src/Aspire.Dashboard/wwwroot/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,3 +817,8 @@ fluent-tooltip[anchor="dialog_close"] > div {
vertical-align: text-bottom;
margin-right: 3px;
}

.resource-actions-url-menuitem::part(content) {
width: 100%;
text-overflow: ellipsis;
}
Loading