Add method to emitting env placeholders #9187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AsEnvPlaceHolder will add an envrionment variable place holder for docker service/file values. - Unknown parameters become env placeholders
github-actions
bot
added
the
area-integrations
mitchdenny
reviewed
May 9, 2025
tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs
Outdated
Show resolved
Hide resolved
captainsafia
reviewed
May 9, 2025
tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs
Outdated
Show resolved
Hide resolved
- Updated CapturedEnvironmentVariables to include a source object. - Modified AddEnvironmentVariable method to accept a source parameter. - Adjusted AsEnvironmentPlaceHolder methods to utilize the new source parameter for better context.
… placeholder and update usage in service extensions
mitchdenny
reviewed
May 9, 2025
mitchdenny
approved these changes
May 9, 2025
davidfowl
commented
May 9, 2025
| return builder; | ||
| } | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
@prom3theu5 This is the pattern we want for helm values for the k8s manifest. I am thinking that before we GA either docker compose or the k8s resource types, the underlying model should be more typed so these aren't strings but something like YamlValue<string> (or maybe we go specific and say it's ComposeValue<T> and KubeValue<T>), that way it's type safe.
We need to:
- Allow going from app model to cdk model
- Preserve the association between the cdk value and the aspire app model somewhere (for later)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist