Skip to content

Conversation

@captainsafia
Copy link
Member

Follow-ups to #9059.

This pull request includes updates to improve naming consistency, clarify code behavior, and reorganize files for better project structure. The key changes include renaming properties in the AzureContainerRegistryResource class, updating comments for clarity, and moving the ContainerRegistryReferenceAnnotation file to a more appropriate namespace.

Naming consistency updates:

  • Renamed properties in AzureContainerRegistryResource to improve clarity and consistency:
    • RegistryName was renamed to NameOutputReference.
    • RegistryEndpoint was renamed to Endpoint.
    • Updated references to these properties throughout the class. [1] [2]

Code behavior clarification:

  • Updated a comment in AzureContainerAppsInfrastructure.cs to clarify that the ComputeEnvironment property will be null when using azd. Removed associated pragma warnings for cleaner code.

File reorganization:

  • Moved ContainerRegistryReferenceAnnotation to the Aspire.Hosting.ApplicationModel namespace and updated its file path to better reflect its purpose and usage.

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label May 6, 2025
@captainsafia captainsafia marked this pull request as ready for review May 7, 2025 00:56
@davidfowl davidfowl merged commit 22223fe into main May 7, 2025
170 checks passed
@davidfowl davidfowl deleted the acr-follow-ups branch May 7, 2025 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants