Skip to content

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented May 4, 2025

Description

  • This publisher walks the model and tries to publish the resource if there's a specific annotation.
  • Added supporting APIs for adding a publisher callback (mimics) the manifest publisher.
  • Don't register publishers for k8s and docker compose anymore, just make those environment resources add publishing annotations.
  • DockerComposeEnvironmentResource and KuberentesEnvironmentResource can publish
  • GetDeploymentTarget can return the right target for the annotation

Contributes to #9089

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

- This publisher walks the model and tries to publish the resource if there's a specific annotation.
- Added supporting APIs for adding a publisher callback (mimics) the manifest publisher.
- Don't register publishers for k8s and docker compose anymore, just make those environment resources add publishing annotations.
- DockerComposeEnvironmentResource and KuberentesEnvironmentResource can publish
- GetDeploymentTarget can return the right target for the annotation
@davidfowl davidfowl requested a review from eerhardt May 4, 2025 05:24
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label May 4, 2025
@davidfowl davidfowl requested a review from captainsafia May 4, 2025 05:24
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going. Lets get it merged.

- Change the sample to use a single compute environment switched on a config entry
@davidfowl davidfowl marked this pull request as ready for review May 6, 2025 03:59
@davidfowl davidfowl merged commit 59f9cf8 into main May 6, 2025
170 checks passed
@davidfowl davidfowl deleted the davidfowl/new-publisher branch May 6, 2025 05:29
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants