-
Couldn't load subscription status.
- Fork 710
Implement new "default" publisher #9096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This publisher walks the model and tries to publish the resource if there's a specific annotation. - Added supporting APIs for adding a publisher callback (mimics) the manifest publisher. - Don't register publishers for k8s and docker compose anymore, just make those environment resources add publishing annotations. - DockerComposeEnvironmentResource and KuberentesEnvironmentResource can publish - GetDeploymentTarget can return the right target for the annotation
mitchdenny
reviewed
May 4, 2025
mitchdenny
approved these changes
May 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is going. Lets get it merged.
…tAnnotation when available
… environments and enhance error messaging
eerhardt
reviewed
May 5, 2025
eerhardt
reviewed
May 5, 2025
eerhardt
reviewed
May 5, 2025
src/Aspire.Hosting/ApplicationModel/PublishingCallbackAnnotation.cs
Outdated
Show resolved
Hide resolved
- Change the sample to use a single compute environment switched on a config entry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #9089
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate