Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 14, 2025

Description

Added URLs to menus in console logs and the graph context menu. URLs open in a new window when clicked.

image

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Member

@adamint adamint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there also be a menu in the resource details view?

@JamesNK
Copy link
Member Author

JamesNK commented Apr 14, 2025

In that case the menu on the resources grid is available.

@JamesNK JamesNK enabled auto-merge (squash) April 14, 2025 22:45
@JamesNK JamesNK force-pushed the jamesnk/context-menu-urls branch from 1040d94 to fe19487 Compare April 14, 2025 22:53
@JamesNK JamesNK merged commit caf5547 into main Apr 14, 2025
174 checks passed
@JamesNK JamesNK deleted the jamesnk/context-menu-urls branch April 14, 2025 23:11
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants