Add hidden --cli-otlp-endpoint switch. #8611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
mitchdenny
changed the title
danmoseley
reviewed
Apr 8, 2025
| } | ||
| }); | ||
| otelOption.Recursive = true; | ||
| otelOption.Hidden = true; // Hiding for now since this could be confusing about what it does. |
There was a problem hiding this comment.
should we obfuscate the name? or --cli-otlp-endpoint-experimental-only ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes from using the standard OTEL environment variable to turn on OTEL for the CLI to a dedicated (but hidden) switch where you specify the URL. The reason this is hidden is that because Aspire itself deals with telemetry we didn't want people thinking this switch somehow overrode the default OTEL configuration injection for resources running the app host.
This switch is purely for diagnostic purposes around the CLI itself and we didn't want it to be reactive to standard OTEL switches.
otel-switch.mp4