Skip to content

Conversation

@davidfowl
Copy link
Member

Description

Rename WithResourceRelationship to WithReferenceRelationship

@davidfowl davidfowl requested review from JamesNK and Copilot March 31, 2025 07:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Renames methods to improve consistency by replacing "WithResourceRelationship" with "WithReferenceRelationship" across multiple files.

  • Updated method calls in ResourceBuilderExtensions.cs, ConnectionStringBuilderExtensions.cs, and AzureBicepResourceExtensions.cs.
  • Renamed method definitions and their invocations to reflect the new naming convention.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Aspire.Hosting/ResourceBuilderExtensions.cs Replaced method calls and definitions from WithResourceRelationship to WithReferenceRelationship.
src/Aspire.Hosting/ConnectionStringBuilderExtensions.cs Updated invocation to use WithReferenceRelationship.
src/Aspire.Hosting.Azure/AzureBicepResourceExtensions.cs Modified method calls to invoke WithReferenceRelationship instead of WithResourceRelationship.

@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 31, 2025
@davidfowl davidfowl merged commit 8ad1d4b into main Mar 31, 2025
172 checks passed
@davidfowl davidfowl deleted the davidfowl/rename-relationship-method branch March 31, 2025 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants