Skip to content

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Mar 13, 2025

Added the azure publisher

  • Added the azure publisher whose job it is to gather bicep resources into both a main.bicep and to gather all deployment target resources into sub folders that will be deployed separately.
  • Added tests

@davidfowl davidfowl requested a review from mitchdenny March 13, 2025 07:52
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 13, 2025
@davidfowl davidfowl requested a review from eerhardt March 13, 2025 07:52
@davidfowl davidfowl marked this pull request as ready for review March 15, 2025 17:12
@davidfowl davidfowl changed the title Add Azure publisher support and related infrastructure files Introduce the azure publisher Mar 15, 2025
@davidfowl davidfowl force-pushed the davidfowl/azure-publisher branch from 1c7a9f1 to 91eb64c Compare March 15, 2025 18:14
- Add experimental attribute to AddAzurePublisher to that stiches all
bicep modules together in main.bicep
- Added tests
@davidfowl davidfowl force-pushed the davidfowl/azure-publisher branch from 91eb64c to eb28a59 Compare March 15, 2025 18:14
}
};

// REVIEW: Do we want people to be able to change this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially provide an override. I think some people dislike the whole rg- thing (I do, it reminds me of warts on variable names).

But I think we should keep it as default for back compat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Via options for sure.

@davidfowl davidfowl merged commit 689835f into main Mar 16, 2025
162 checks passed
@davidfowl davidfowl deleted the davidfowl/azure-publisher branch March 16, 2025 22:54
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants