Skip to content

Conversation

@sebastienros
Copy link
Member

Description

Health-checks currently use the wrong name property for Service Bus emulator. It doesn't work anymore when users provide a custom name.

Fixes #7904

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@sebastienros sebastienros requested review from Copilot and eerhardt and removed request for Copilot March 12, 2025 20:14
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 12, 2025
@sebastienros
Copy link
Member Author

I am realizing (due to the merge) this was fixed yesterday. We may still want the functional tests update, even though we don't run it in CI right now (instability).

#7997

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the same test for EventHubs?

@sebastienros
Copy link
Member Author

@eerhardt added same logic for EH

@sebastienros
Copy link
Member Author

/cc @cyrusdargahi

@sebastienros sebastienros merged commit e05e202 into main Mar 12, 2025
160 checks passed
@sebastienros sebastienros deleted the sebros/sbemulatorchecks branch March 12, 2025 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure service bus emulator does not start

3 participants