-
Notifications
You must be signed in to change notification settings - Fork 715
Create database for Sql Server resource #8022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f50d0f6
Create SQL Server database automatically
sebastienros 93efeb2
Update tests to ensure new dbs are created
sebastienros 8b88f42
Create SQL Server container folders on Windows
sebastienros 4dda707
Test custom creation script annotations
sebastienros 37a9720
Revert playground changes
sebastienros ab9548d
Ensure special names are encoded in the creation script
sebastienros fa47903
PR feedback
sebastienros c3761c2
Formatting
sebastienros 1d8456c
Feedback
sebastienros 0a97670
Add support for multi-statements scripts
sebastienros 8ef42a6
Improve GO separator support
sebastienros b9d281c
Fix build
sebastienros 61875ef
Regex feedback and tests
sebastienros c5e6841
Update src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs
sebastienros 98780b4
Fix test and remove private reflection
sebastienros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
src/Aspire.Hosting/ApplicationModel/CreationScriptAnnotation.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| namespace Aspire.Hosting.ApplicationModel; | ||
|
|
||
| /// <summary> | ||
| /// Represents an annotation for defining a script to create a resource. | ||
| /// </summary> | ||
| public sealed class CreationScriptAnnotation : IResourceAnnotation | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="CreationScriptAnnotation"/> class. | ||
| /// </summary> | ||
| /// <param name="script">The script used to create the resource.</param> | ||
| public CreationScriptAnnotation(string script) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(script); | ||
| Script = script; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the script used to create the resource. | ||
| /// </summary> | ||
| public string Script { get; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the difference between the name in the WHERE and the name used on the Create Database? Shouldn't they both use the same SqlParameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameters can't be used for object names (such as database names, table names, or column names).
It's used in the query part because in that case it's a string value.