Fix named configuration handling in DbContext-based clients #8014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
eerhardt,
radical and
sebastienros
as code owners
github-actions
bot
added
the
area-integrations
There was a problem hiding this comment.
Pull Request Overview
This PR fixes named configuration handling for DbContext‐based clients by ensuring that connection-specific settings override general settings when provided. Key changes include:
- Adding tests for various providers (Npgsql, Cosmos, MySql, SQL Server, and Oracle) to verify that connection names correctly apply configuration settings.
- Updating extension methods in multiple components to support an optional connectionName parameter in the GetDbContextSettings helper.
- Enhancing configuration resource injection for Azure CosmosDB to align with the new naming scheme.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests/AspireEFPostgreSqlExtensionsTests.cs | Introduces tests for Npgsql that verify connection-specific settings. |
| tests/Aspire.Microsoft.EntityFrameworkCore.Cosmos.Tests/AspireAzureEfCoreCosmosDBExtensionsTests.cs | Adds tests for Cosmos DB to ensure connection and context-specific settings behave as intended. |
| tests/Aspire.Pomelo.EntityFrameworkCore.MySql.Tests/AspireEFMySqlExtensionsTests.cs | Implements tests for MySql verifying the application of connection-specific settings. |
| tests/Aspire.Microsoft.EntityFrameworkCore.SqlServer.Tests/AspireSqlServerEFCoreSqlClientExtensionsTests.cs | Provides tests for SQL Server to confirm that context-specific settings take precedence. |
| tests/Aspire.Oracle.EntityFrameworkCore.Tests/AspireOracleEFCoreDatabaseExtensionsTests.cs | Adds tests for Oracle to validate correct settings application. |
| src/Aspire.Hosting.Azure.CosmosDB/AzureCosmosDBResource.cs | Updates resource configuration insertion for CosmosDB to support EF Core. |
| src/Components/Common/EntityFrameworkUtils.cs | Modifies GetDbContextSettings to include an optional connectionName parameter and bind connection-specific settings. |
| src/Components/* | Various provider-specific EF Core extension classes now pass connectionName or null appropriately to GetDbContextSettings. |
...spire.Microsoft.EntityFrameworkCore.Cosmos.Tests/AspireAzureEfCoreCosmosDBExtensionsTests.cs
Show resolved
Hide resolved
eerhardt
reviewed
Mar 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #5826.
Closes #7785.