[release/9.1] Support WithEntrypoint on Containers #7582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ACA infrastructure wasn't respecting the entrypoint on a ContainerResource. To fix this, set the container command to the entrypoint, if it is supplied. Fix #7576
sebastienros
approved these changes
Feb 13, 2025
davidfowl
approved these changes
Feb 13, 2025
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7577 to release/9.1
/cc @eerhardt
Customer Impact
When devs try to set the entrypoint on a container (
.WithEntrypoint), it isn't flowing to ACA. So their container might start, but the command isn't executed correctly.Testing
Added a new test to ensure the bicep we generate is correct.
Risk
Super small. This only affects our ACA bicep generation, and only if the Entrypoint is set.
Regression?
No