Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 12, 2025

Description

I noticed when the dashboard receives telemetry with new instruments, the instruments aren't automatically added to an open metrics page.

Fix + test.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK
Copy link
Member Author

JamesNK commented Feb 12, 2025

/backport to release/9.1

@dotnet dotnet deleted a comment from github-actions bot Feb 12, 2025
Copy link
Contributor

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt merged commit b8cc385 into main Feb 12, 2025
70 checks passed
@eerhardt eerhardt deleted the jamesnk/metrics-page-fix branch February 12, 2025 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants