Skip to content

Conversation

@eerhardt
Copy link
Member

Description

Reverts Add Password To Redis (dotnet/aspire#4642).

azd doesn't allow for secret parameters to be used in command line args of containers. See the code comment here.

		// Unlike environment variables, ACA doesn't provide a way to pass secret values without baking them into the args
		// array directly. We don't want folks to accidentally bake the plaintext value of these secrets into the container
		// definition, so for now, we block this.
		//
		// This logic is similar to what we do in buildEnvBlock to detect when we need to take values and treat them as ACA
		// secrets.

For .NET Aspire 9.1, we will revert back to the 9.0 behavior for Redis containers. We will revisit this issue in 9.2 to decide how we can password protect Redis containers in ACA.

Fixes #7429

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
  • Does the change require an update in our Aspire docs?
    • No

"principalId": ""
}
},
"eventhub": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - These are caused by other changes that didn't update the playground manifests.

@eerhardt eerhardt enabled auto-merge (squash) February 11, 2025 01:07
@eerhardt eerhardt merged commit 6a9540c into dotnet:main Feb 11, 2025
70 checks passed
@eerhardt eerhardt deleted the RevertRedisPassword branch February 11, 2025 15:59
Alirexaa added a commit to Alirexaa/aspire that referenced this pull request Feb 13, 2025
eerhardt added a commit that referenced this pull request Feb 26, 2025
This PR addresses the previous issue by changing the container entrypoint and providing the password from an environment variable.

* Revert "Revert redis password change (#7518)"

This reverts commit 6a9540c.

* checkout eventhubns.module.bicep and eventhubs aspire-manifest.json

* Set password from envs

* Add redis-command in single arg instead of multiple args

* Update playground manifest

* Address PR feedback

* Respond to PR feedback

* Change Redis password generation to exclude special characters.

SE.Redis doesn't support commas in the password when parsing the connection string.

* Fix ACA bug with HostAndPort

* Always display the port for HostAndPort

Fix #3838

---------

Co-authored-by: Eric Erhardt <[email protected]>
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

3 participants