-
Notifications
You must be signed in to change notification settings - Fork 727
Revert redis password change #7518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
commented
Feb 10, 2025
| "principalId": "" | ||
| } | ||
| }, | ||
| "eventhub": { |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - These are caused by other changes that didn't update the playground manifests.
davidfowl
approved these changes
Feb 10, 2025
ReubenBond
approved these changes
Feb 10, 2025
Alirexaa
added a commit
to Alirexaa/aspire
that referenced
this pull request
Feb 13, 2025
This reverts commit 6a9540c.
eerhardt
added a commit
that referenced
this pull request
Feb 26, 2025
This PR addresses the previous issue by changing the container entrypoint and providing the password from an environment variable. * Revert "Revert redis password change (#7518)" This reverts commit 6a9540c. * checkout eventhubns.module.bicep and eventhubs aspire-manifest.json * Set password from envs * Add redis-command in single arg instead of multiple args * Update playground manifest * Address PR feedback * Respond to PR feedback * Change Redis password generation to exclude special characters. SE.Redis doesn't support commas in the password when parsing the connection string. * Fix ACA bug with HostAndPort * Always display the port for HostAndPort Fix #3838 --------- Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts Add Password To Redis (dotnet/aspire#4642).
azddoesn't allow for secret parameters to be used in command line args of containers. See the code comment here.For .NET Aspire 9.1, we will revert back to the 9.0 behavior for Redis containers. We will revisit this issue in 9.2 to decide how we can password protect Redis containers in ACA.
Fixes #7429
Checklist