[Automated] Update API Surface Area #7374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ReubenBond,
eerhardt,
radical and
sebastienros
as code owners
joperezr
added
the
NO-MERGE
|
FYI: @davidfowl @eerhardt |
davidfowl
reviewed
Feb 3, 2025
davidfowl
reviewed
Feb 3, 2025
davidfowl
reviewed
Feb 3, 2025
davidfowl
reviewed
Feb 3, 2025
src/Aspire.Hosting.Azure.EventHubs/api/Aspire.Hosting.Azure.EventHubs.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
02609f0 to
677fdfe
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/Components/Aspire.Azure.AI.OpenAI/api/Aspire.Azure.AI.OpenAI.cs: Evaluated as low risk
- src/Components/Aspire.MongoDB.Driver.v3/api/Aspire.MongoDB.Driver.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.EventHubs/api/Aspire.Hosting.Azure.EventHubs.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.PostgreSQL/api/Aspire.Hosting.Azure.PostgreSQL.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.Redis/api/Aspire.Hosting.Azure.Redis.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.ServiceBus/api/Aspire.Hosting.Azure.ServiceBus.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.SignalR/api/Aspire.Hosting.Azure.SignalR.cs: Evaluated as low risk
- src/Components/Aspire.NATS.Net/api/Aspire.NATS.Net.cs: Evaluated as low risk
- src/Components/Aspire.OpenAI/api/Aspire.OpenAI.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.CosmosDB/api/Aspire.Hosting.Azure.CosmosDB.cs: Evaluated as low risk
- src/Components/Aspire.Confluent.Kafka/api/Aspire.Confluent.Kafka.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.AppContainers/api/Aspire.Hosting.Azure.AppContainers.cs: Evaluated as low risk
- src/Aspire.Hosting/api/Aspire.Hosting.cs: Evaluated as low risk
- src/Aspire.Hosting.Keycloak/api/Aspire.Hosting.Keycloak.cs: Evaluated as low risk
- src/Aspire.Hosting.Redis/api/Aspire.Hosting.Redis.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Aspire.Hosting.Nats/api/Aspire.Hosting.Nats.cs:32
- The
userNameandpasswordparameters are optional but are not being checked for null values when being set in theNatsServerResourceconstructor. This could lead to potential null reference exceptions if these parameters are accessed without null checks elsewhere in the code. Consider adding null checks or handling these parameters appropriately.
public NatsServerResource(string name, ParameterResource? userName, ParameterResource? password) : base(default!, default) { }
f206793 to
7fa712f
Compare
davidfowl
reviewed
Feb 5, 2025
davidfowl
reviewed
Feb 5, 2025
davidfowl
reviewed
Feb 5, 2025
davidfowl
reviewed
Feb 5, 2025
github-actions
bot
force-pushed
the
update-api-diffs
branch
2 times, most recently
from
aaa45ff to
483f443
Compare
davidfowl
reviewed
Feb 8, 2025
davidfowl
reviewed
Feb 8, 2025
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
483f443 to
aac97bd
Compare
davidfowl
reviewed
Feb 8, 2025
davidfowl
reviewed
Feb 8, 2025
davidfowl
reviewed
Feb 8, 2025
github-actions
bot
force-pushed
the
update-api-diffs
branch
2 times, most recently
from
e980bc9 to
7117075
Compare
captainsafia
added a commit
that referenced
this pull request
Feb 18, 2025
…Config Reaction to #7374 (comment).
captainsafia
added a commit
that referenced
this pull request
Feb 19, 2025
…Config (#7667) Reaction to #7374 (comment).
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…Config Reaction to #7374 (comment).
danmoseley
pushed a commit
that referenced
this pull request
Feb 19, 2025
…Config (#7675) Reaction to #7374 (comment). Co-authored-by: Safia Abdalla <[email protected]>
danmoseley
reviewed
Feb 19, 2025
src/Aspire.Hosting.Azure.CosmosDB/api/Aspire.Hosting.Azure.CosmosDB.cs
Outdated
Show resolved
Hide resolved
danmoseley
reviewed
Feb 19, 2025
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
7117075 to
42e86c9
Compare
8 tasks
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
42e86c9 to
6f09a08
Compare
eerhardt
reviewed
Feb 20, 2025
github-actions
bot
force-pushed
the
update-api-diffs
branch
2 times, most recently
from
b941209 to
e9551ec
Compare
github-actions
bot
force-pushed
the
update-api-diffs
branch
from
e9551ec to
0d158b4
Compare
|
Need signoffs to merge this -- @mitchdenny , @eerhardt ? |
No. I think |
mitchdenny
reviewed
Feb 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.