Skip to content

Fix path to TestShop.AppHost in contributing.md #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix path to TestShop.AppHost in contributing.md #6480

merged 1 commit into from
Oct 24, 2024

Conversation

mfcollins3
Copy link
Contributor

@mfcollins3 mfcollins3 commented Oct 24, 2024 •
edited by dotnet-policy-service bot
Loading

Description

The instructions in contributing.md for running the TestShop AppHost project had an incorrect path. I corrected the documentation with the correct path so that the instructions are accurate.

Fixes #6479

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mfcollins3
Fix path to TestShop.AppHost in contributing.md
9a961a0 
The instructions in contributing.md for running the TestShop AppHost
project had an incorrect path. I corrected the documentation with the
correct path so that the instructions are accurate.

Resolves dotnet#6479
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 24, 2024
@radical radical merged commit d2492f5 into dotnet:main Oct 24, 2024
4 checks passed
@radical
Copy link
Member

radical commented Oct 24, 2024

Thank you for the PR!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad path for TestShop host in docs/contributing.md

2 participants

@mfcollins3 @radical