[release/9.0] Mark Aspire.Hosting.Python as experimental #6460
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
|
aspire/src/Aspire.Hosting.Python/Aspire.Hosting.Python.csproj Lines 9 to 10 in b1549df This needs to be removed. |
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
|
|
||
| [assembly: Experimental("ASPIREHOSTINGPYTHON001", UrlFormat = "https://aka.ms/dotnet/aspire/diagnostics#{0}")] |
There was a problem hiding this comment.
Just to make sure, is the intention really to mark ALL APIs as experimental as opposed to just the new ones? Presumably we would want to keep the other ones not as experimental and instead just obsolete them?
There was a problem hiding this comment.
There was a problem hiding this comment.
From what I am seeing in the PublicAPI files, all previous have been obsoleted, so everything is new. And everything is
- one resource (PythonAppResource)
- two extension methods (AddPythonApp)
There was a problem hiding this comment.
Yes, I think we just make ALL APIs in this library Experimental for 9.0. All the previous APIs are obsolete. And all the new APIs are experimental.
|
We need to take this change for Aspire.Hosting.Python, so this does meet the bar and is approved. Let's just make sure we get confirmation on the question I asked above. |
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
|
|
||
| [assembly: Experimental("ASPIREHOSTINGPYTHON001", UrlFormat = "https://aka.ms/dotnet/aspire/diagnostics#{0}")] |
There was a problem hiding this comment.
Yes, I think we just make ALL APIs in this library Experimental for 9.0. All the previous APIs are obsolete. And all the new APIs are experimental.
…/9.0 #### AI description (iteration 1) #### PR Classification Code cleanup and dependency updates. #### PR Summary This pull request merges changes from `release/9.0` into `internal/release/9.0`, addressing several work items related to security, dependency updates, and code cleanup. - Removed `MilvusClient` creation logic and health checks from `src/Aspire.Hosting.Milvus/MilvusBuilderExtensions.cs`. - Updated various package dependencies in `Directory.Packages.props` and `eng/Version.Details.xml`. - Added `AssemblyInfo.cs` to `src/Aspire.Hosting.Python` to mark it as experimental. - Updated container image tags in `src/Aspire.Hosting.Milvus`, `src/Aspire.Hosting.MySql`, `src/Aspire.Hosting.Elasticsearch`, and `src/Aspire.Hosting.Keycloak`. - Removed deprecated package references and suppressed final package version in `src/Aspire.Hosting.Milvus/Aspire.Hosting.Milvus.csproj`. Related work items: dotnet#5994, dotnet#6054, dotnet#6298, dotnet#6377, dotnet#6417, dotnet#6435, dotnet#6451, dotnet#6460, dotnet#6498
github-actions
bot
added
the
area-integrations
3 participants
Backport of #6434 to release/9.0
/cc @sebastienros
Customer Impact
Testing
Risk
Regression?
Microsoft Reviewers: Open in CodeFlow