[release/9.0] Show exception details in text visualizer dialog #6426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Exception details are shown behind a button in two places: 1. In the "Message" column of the structured logs table, when an exception exists. 2. In the "Health reports" grid in resource details, when a health report includes exception details. Previously, the stack trace would be shown in a popup when the mouse hovered over the icon, sort of like a tooltip. This commit changes the behaviour so that exception details are shown in the existing text visualizer dialog whenever the icon is clicked. The icon becomes a `FluentButton` for consistency with the menu button to the right of the cell. Also some optimisations in `GridValue`: - Don't use `FluentHighlighter` when the text to highlight is empty, which will be the common case. This improves UI performance. - Remove `MaxDisplayLength`. We never set this property, and it used space on every `GridValue` instance, and we create a lot of these objects. - Remove some redundant DOM elements. - Support adding arbitrary buttons to the right-hand side of the area (used for the "exception details" button).
|
Low Risk, manual validation, and great improvement on experience. Approved for 9.0 |
joperezr
approved these changes
Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6230 to release/9.0
/cc @drewnoakes
Customer Impact
Testing
Plenty of manual testing in addition to the automated tests.
Risk
Low. This UI component is contained.
Regression?
Microsoft Reviewers: Open in CodeFlow