[release/9.0] Enable signing and mark packages as stable #6388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joperezr
commented
Oct 19, 2024
| <VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix> | ||
| <PreReleaseVersionLabel Condition="'$(SuppressFinalPackageVersion)' != 'true'">rc.2</PreReleaseVersionLabel> | ||
| <PreReleaseVersionLabel Condition="'$(PreReleaseVersionLabel)' == ''">preview.5</PreReleaseVersionLabel> | ||
| <PreReleaseVersionLabel>preview.5</PreReleaseVersionLabel> |
There was a problem hiding this comment.
We no longer need the distinction as packages will be stable or preview 5 depending or not if their stable version is being suppressed
joperezr
commented
Oct 19, 2024
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| <Target Name="ValidatePreReleaseLabelIsCorrectForPreviewPackages" |
There was a problem hiding this comment.
We no longer need this target as we are no longer producing different prerelease labels.
joperezr
commented
Oct 19, 2024
| <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation> | ||
| <PackageValidationBaselineVersion Condition="'$(EnablePackageValidation)' == 'true' and '$(PackageValidationBaselineVersion)' == ''">$(BaselineVersionForPackageValidation)</PackageValidationBaselineVersion> | ||
| <!-- For Aspire.Hosting.Azure* packages, we need to ingest the new Azure.Provisioning stable packages in order for us to produce stable bits. --> | ||
| <SuppressFinalPackageVersion Condition="$(MSBuildProjectName.StartsWith('Aspire.Hosting.Azure'))">true</SuppressFinalPackageVersion> |
There was a problem hiding this comment.
This is temporary and will get removed once we ingest the stable version of Azure.Provisioning. cc: @eerhardt @davidfowl
joperezr
commented
Oct 19, 2024
| <Description>A PostgreSQL® provider for Entity Framework Core that integrates with Aspire, including connection pooling, health checks, logging, and telemetry.</Description> | ||
| <PackageIconFullPath>$(SharedDir)PostgreSQL_logo.3colors.540x557.png</PackageIconFullPath> | ||
| <!-- We need to ingest the stable version of EF and npgsql in order for us to produce stable bits. --> | ||
| <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion> |
There was a problem hiding this comment.
FYI: @eerhardt will need to figure out what to do about this one given the npgsql dependency.
Open
3 tasks
|
Merging in favor of getting a release/9.0 build to test. Will address any follow up questions in a follow up PR. |
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will enable signing in our builds, as well as marking the packages as stable. Some packages will not be able to be marked stable yet as we need to flow some dependencies yet, so those will be marked as unstable for now.
Microsoft Reviewers: Open in CodeFlow