Add missing port configuration to AddAzurePostgresFlexibleServer RunAsContainer

[gabynevada]

Description

The AddAzurePostgresFlexibleServer RunAsContainer does not have an exposed property to specify the running port like the AddPostgres method allows. This change adds the optional parameter to RunAsContainer and forwards it to the AddPostgres method used internally.

• Added the same port parameter used on the AddPostgres method
• Documented new parameter on RunAsContainer method
• Updated public api reference

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue:
  • No

Microsoft Reviewers: Open in CodeFlow

[gabynevada]

@dotnet-policy-service agree

[davidfowl]

@eerhardt Can you review? I think we want this for azure pg,sql and redis.

cc @mitchdenny as well.

[mitchdenny]

To be consistent we'd probably have something like WithHostPort

[davidfowl]

To be consistent we'd probably have something like WithHostPort

Are we going to do that for all containers? Just these 3? I Think we expose the actual container resource so that means WithHostPort will show up on all of these resources.

[eerhardt]

To be consistent we'd probably have something like WithHostPort

Are we going to do that for all containers? Just these 3? I Think we expose the actual container resource so that means WithHostPort will show up on all of these resources.

I don't think the current PR code is want it this way. We don't have this port parameter for CosmosDB or Azure Storage emulators. But instead you are expected to write:

builder.AddAzureCosmosDB("cosmos")
    .RunAsEmulator(container =>
    {
        container.WithGatewayPort(9000);
    });

builder.AddAzureStorage("storage")
    .RunAsEmulator(configureContainer: builder =>
    {
        builder.WithBlobPort(9001);
        builder.WithQueuePort(9002);
        builder.WithTablePort(9003);
    });

So instead, for PostgreSQL we should have:

builder.AddAzurePostgresFlexibleServer("pgsql")
    .RunAsContainer(configureContainer: builder =>
    {
        builder.WithHostPort(9004);
    });

[gabynevada]

@eerhardt @mitchdenny Added requested changes for the PostgresServerResource.

Some follow up questions:

• Is this the expected design?
• Are other resource changes needed in this PR?

[mitchdenny]

@gabynevada apologies for the slow response here. I think we'll look to take this in 9.1.

[eerhardt]

Thank you for your contribution and suggestion @gabynevada!

I'm going to close this PR in favor of Add ability to configure Port and Password for Redis and Postgres and SqlServer when they configured to run by RunAsContainer (dotnet/aspire#8439), since that PR contains the full fix for other resources as well.