Skip to content

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Oct 3, 2024

Description

This PR adds a health check to the EventHubs emulator so it works with WaitFor.

Related #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny requested a review from davidfowl October 3, 2024 00:11
@mitchdenny mitchdenny self-assigned this Oct 3, 2024
@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages azure-eventhubs Issues related to Azure Event Hubs integration labels Oct 3, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Oct 3, 2024
@davidfowl
Copy link
Member

cc @oising

@davidfowl
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny force-pushed the mitchdenny/waitfor-eventhubs-emulator branch from d14e0d7 to 4e12ebd Compare October 3, 2024 07:22
@mitchdenny mitchdenny enabled auto-merge (squash) October 3, 2024 08:14
@mitchdenny mitchdenny merged commit 820b33c into main Oct 3, 2024
9 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/waitfor-eventhubs-emulator branch October 3, 2024 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages azure-eventhubs Issues related to Azure Event Hubs integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants