Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 26, 2024

Description

I got an error when visiting span details when a span has multiple events at the same time. Also, the span and details headers on links and backlinks sections were disabled.

This PR:

  • Adds internal id to span events and uses it as the item key in the UI
  • Uses normal headers for span and details headers

After:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Member Author

JamesNK commented Sep 26, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit 9b850d7 into main Sep 30, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/span-details-fixes branch September 30, 2024 03:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants