Skip to content

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 18, 2024

Description

Adding WaitFor(...) support for Azure Storage. This one ended up being a bit more involved than normal because Azure storage is one of the few resources that has a parent resource that does not have a connection string, whereas child resources do.

To make this work I've centralized propagation of the ConnectionStringAvailableEvent events for child resource and removed it from the extension methods for each resource.

Fixes #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny self-assigned this Sep 18, 2024
@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages azure-storage Issues related to azure storage integration labels Sep 18, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Sep 18, 2024
@mitchdenny mitchdenny marked this pull request as ready for review September 30, 2024 08:49
Co-authored-by: David Fowler <[email protected]>
@mitchdenny
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny requested a review from davidfowl October 2, 2024 00:29
}

private async Task CreateExecutableAsync(AppResource er, ILogger resourceLogger, CancellationToken cancellationToken)
private async Task PublishConnectionStringAvailableEvent(IResource resource, CancellationToken cancellationToken)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this still?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we still have resources that depend on it (Postgres/Redis etc).

@mitchdenny mitchdenny merged commit d0d3ce5 into main Oct 2, 2024
9 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/waitfor-azure-storage branch October 2, 2024 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages azure-storage Issues related to azure storage integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WaitFor: Add health checks to remaining resources

3 participants