Skip to content

Conversation

@Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Sep 16, 2024

Adds WaitFor support for Oracle

Related: #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-components label Sep 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 16, 2024
@Alirexaa
Copy link
Contributor Author

@mitchdenny, could you import AspNetCore.HealthChecks.Oracle to package sources?

Also, I could not check test passing on my machine, the Oracle container consumes too many resources.

@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages and removed area-components labels Sep 16, 2024
@mitchdenny
Copy link
Member

@mitchdenny, could you import AspNetCore.HealthChecks.Oracle to package sources?

Also, I could not check test passing on my machine, the Oracle container consumes too many resources.

Importing now.

@mitchdenny
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit f0c013d into dotnet:main Sep 18, 2024
@Alirexaa Alirexaa deleted the waitfor-oracle branch September 19, 2024 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants