Skip to content

WaitFor for Cosmos DB #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2024
Merged

WaitFor for Cosmos DB #5729

merged 5 commits into from
Sep 17, 2024

Conversation

@mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 16, 2024 •
edited by dotnet-policy-service bot
Loading

Description

This PR adds WaitFor support for Cosmos DB.

Related #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-components label Sep 16, 2024
@mitchdenny mitchdenny changed the title First pass of getting Cosmos going with Health Checks. WaitFor for Cosmos DB Sep 16, 2024
@mitchdenny mitchdenny mentioned this pull request Sep 16, 2024
Closed
15 tasks
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-cosmosdb Issues related to Azure CosmosDB and removed area-components labels Sep 16, 2024
@mitchdenny mitchdenny force-pushed the mitchdenny/waitfor-cosmos branch from b478258 to 1874bf9 Compare September 17, 2024 03:11
@mitchdenny mitchdenny marked this pull request as ready for review September 17, 2024 03:12
@mitchdenny mitchdenny self-assigned this Sep 17, 2024
@mitchdenny
Copy link
Member Author

mitchdenny commented Sep 17, 2024

This is ready. I held it in draft until I understood the issue with WithLifetime(...) not working the way I expected, but that is this issue: #5741

davidfowl
davidfowl reviewed Sep 17, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Sep 17, 2024
Closed
@mitchdenny mitchdenny enabled auto-merge (squash) September 17, 2024 06:17
@build-analysis build-analysis bot mentioned this pull request Sep 17, 2024
Open
3 tasks
@davidfowl
Copy link
Member

davidfowl commented Sep 17, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 17, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit 2cb078e into main Sep 17, 2024
@mitchdenny mitchdenny deleted the mitchdenny/waitfor-cosmos branch September 17, 2024 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees

@mitchdenny mitchdenny

Labels

area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-cosmosdb Issues related to Azure CosmosDB

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mitchdenny @davidfowl