WaitFor Milvus #5707
Merged
WaitFor Milvus #5707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
davidfowl
added
the
area-integrations
davidfowl
reviewed
Sep 13, 2024
davidfowl
reviewed
Sep 13, 2024
|
Looks like the health check isn't working |
Co-authored-by: David Fowler <[email protected]>
15 tasks
davidfowl
reviewed
Sep 16, 2024
| } | ||
| internal static MilvusClient CreateMilvusClient(IServiceProvider sp, string? connectionString) | ||
| { | ||
| if (connectionString is null) |
There was a problem hiding this comment.
Ideally we would share this logic:
@eerhardt thoughts?
There was a problem hiding this comment.
I agree with @davidfowl we should do this because the created Milvus connection string in app-host isn't compatible with MilvusClient and those properties (database, endpoint, key) should be extracted before creating MilvusClient.
There was a problem hiding this comment.
Was there a reason this wasn't done?
davidfowl
approved these changes
Sep 17, 2024
mitchdenny
reviewed
Sep 17, 2024
|
|
||
| var milvus = new MilvusServerResource(name, apiKeyParameter); | ||
|
|
||
| string? connectionString = null; |
There was a problem hiding this comment.
Probably technically don't need the connection string here since you have the client.
mitchdenny
approved these changes
Sep 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a health check to the host for Milvus resource so that it works with WaitFor.
Related #5645
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow