Skip to content

Extract Aspire.Hosting.Dapr.Tests #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 16, 2024
Merged

Extract Aspire.Hosting.Dapr.Tests #5282

merged 10 commits into from
Aug 16, 2024

Conversation

@sebastienros
Copy link
Member

@sebastienros sebastienros commented Aug 13, 2024 •
edited by dotnet-policy-service bot
Loading

Part of #4294

Microsoft Reviewers: Open in CodeFlow

@sebastienros sebastienros requested review from radical and removed request for mitchdenny August 13, 2024 18:31
@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Aug 13, 2024
@sebastienros sebastienros requested a review from eerhardt August 13, 2024 18:31
@sebastienros sebastienros mentioned this pull request Aug 13, 2024
Closed
20 tasks
davidfowl
davidfowl reviewed Aug 13, 2024
View reviewed changes
radical
radical reviewed Aug 13, 2024
View reviewed changes
eerhardt
eerhardt reviewed Aug 13, 2024
View reviewed changes
src/Aspire.Hosting/Aspire.Hosting.csproj Outdated
<ItemGroup>
<InternalsVisibleTo Include="Aspire.Hosting.Tests" />
<InternalsVisibleTo Include="Aspire.Hosting.Containers.Tests" />
<InternalsVisibleTo Include="Aspire.Hosting.Dapr.Tests" />
Copy link
Member

@eerhardt eerhardt Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change this. We shouldn't be using internals in these tests outside of our core tests. What is this needed for?

Copy link
Member Author

@sebastienros sebastienros Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

await app.ExecuteBeforeStartHooksAsync(default); in DaprTests

Copy link
Member

@eerhardt eerhardt Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we refactor the tests to not need to use an internal API?

Copy link
Member Author

@sebastienros sebastienros Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using UnsafeAccessor instead. It also works if part of this internal method is copied over, but I feel it's more brittle.

@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Aug 13, 2024
eerhardt
eerhardt reviewed Aug 13, 2024
View reviewed changes
@sebastienros
Copy link
Member Author

sebastienros commented Aug 13, 2024

@radical

Is it possible that the helix jobs don't have all the required files? This works locally.

[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.3+1b45f5407b (64-bit .NET 8.0.7)
[xUnit.net 00:00:03.43]   Discovering: Aspire.Hosting.Dapr.Tests
[xUnit.net 00:00:03.47]   Discovered:  Aspire.Hosting.Dapr.Tests
[xUnit.net 00:00:03.47]   Starting:    Aspire.Hosting.Dapr.Tests
[xUnit.net 00:00:03.62]     Aspire.Hosting.Dapr.Tests.DaprSchemaTests.ValidateWithDaprManifest [FAIL]
[xUnit.net 00:00:03.62]       Aspire.Hosting.DistributedApplicationException : Project file 'D:\a\_work\1\s\tests\testproject\TestProject.ServiceA\TestProject.ServiceA.csproj' was not found.
[xUnit.net 00:00:03.62]       Stack Trace:
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/LaunchProfileExtensions.cs(66,0): at Aspire.Hosting.LaunchProfileExtensions.GetLaunchSettings(IProjectMetadata projectMetadata, String resourceName)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/LaunchProfileExtensions.cs(28,0): at Aspire.Hosting.LaunchProfileExtensions.GetLaunchSettings(ProjectResource projectResource)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/LaunchProfileExtensions.cs(106,0): at Aspire.Hosting.LaunchProfileExtensions.TrySelectLaunchProfileByOrder(ProjectResource projectResource, String& launchProfileName)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/LaunchProfileExtensions.cs(168,0): at Aspire.Hosting.LaunchProfileExtensions.SelectLaunchProfileName(ProjectResource projectResource)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/LaunchProfileExtensions.cs(33,0): at Aspire.Hosting.LaunchProfileExtensions.GetEffectiveLaunchProfile(ProjectResource projectResource, Boolean throwIfNotFound)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs(318,0): at Aspire.Hosting.ProjectResourceBuilderExtensions.WithProjectDefaults(IResourceBuilder`1 builder, ProjectResourceOptions options)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs(216,0): at Aspire.Hosting.ProjectResourceBuilderExtensions.AddProject[TProject](IDistributedApplicationBuilder builder, String name, Action`1 configure)
[xUnit.net 00:00:03.62]         /_/src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs(63,0): at Aspire.Hosting.ProjectResourceBuilderExtensions.AddProject[TProject](IDistributedApplicationBuilder builder, String name)
[xUnit.net 00:00:03.62]         /_/tests/Aspire.Hosting.Dapr.Tests/DaprSchemaTests.cs(24,0): at Aspire.Hosting.Dapr.Tests.DaprSchemaTests.<>c.<ValidateWithDaprManifest>b__0_0(IDistributedApplicationBuilder builder)
[xUnit.net 00:00:03.62]         /_/tests/Aspire.Hosting.Tests/Schema/SchemaTests.cs(184,0): at Aspire.Hosting.Tests.Schema.SchemaTests.ValidateApplicationSamples(String testCaseName, Action`1 configurator)
[xUnit.net 00:00:03.62]         /_/tests/Aspire.Hosting.Dapr.Tests/DaprSchemaTests.cs(14,0): at Aspire.Hosting.Dapr.Tests.DaprSchemaTests.ValidateWithDaprManifest()
[xUnit.net 00:00:03.62]            at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
[xUnit.net 00:00:03.62]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
[xUnit.net 00:00:03.72]   Finished:    Aspire.Hosting.Dapr.Tests

eerhardt
eerhardt reviewed Aug 13, 2024
View reviewed changes
eerhardt
eerhardt reviewed Aug 13, 2024
View reviewed changes
@sebastienros sebastienros enabled auto-merge (squash) August 13, 2024 23:09
@radical
Copy link
Member

radical commented Aug 14, 2024

We should add https://github.com/dotnet/aspire/blob/main/tests/Aspire.Workload.Tests/xunit.runner.json +

aspire/tests/Aspire.Workload.Tests/Aspire.Workload.Tests.csproj

Line 9 in d431c28

<XunitRunnerJson>xunit.runner.json</XunitRunnerJson>
to the playground tests. That would should us which test is stuck, and for how long.

@radical
Copy link
Member

radical commented Aug 14, 2024

It has "longRunningTestSeconds": 120,.

@build-analysis build-analysis bot mentioned this pull request Aug 14, 2024
Closed
@radical
Merge remote-tracking branch 'origin/main' into sebros/extractdapr
9e7c64a 
# Conflicts:
#	Aspire.sln
#	tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj
#	tests/Aspire.Hosting.Tests/Schema/SchemaTests.cs
@radical
Copy link
Member

radical commented Aug 14, 2024

Fixed the conflicts.

@sebastienros
Copy link
Member Author

sebastienros commented Aug 15, 2024 •
edited
Loading

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros
Copy link
Member Author

sebastienros commented Aug 16, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros sebastienros merged commit 221da9a into main Aug 16, 2024
@sebastienros sebastienros deleted the sebros/extractdapr branch August 16, 2024 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl left review comments

@radical radical radical approved these changes

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastienros @radical @davidfowl @eerhardt