[release/8.0] Fix dashboard log watching #3637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cutable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once. - Deleted the timeout Fixes #3612
ghost
added
the
dotnet-policy-service
bot
added
the
Servicing-consider
JamesNK
approved these changes
Apr 12, 2024
davidfowl
approved these changes
Apr 12, 2024
danmoseley
added
Servicing-approved
Member
|
/backport to release/8.0-preview6 |
Contributor
Author
|
Started backporting to release/8.0-preview6: https://github.com/dotnet/aspire/actions/runs/8664820987 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3636 to release/8.0
/cc @davidfowl
Customer Impact
Testing
Manual testing with a normal dashboard (not just our playground projects). Testing each of the cases to make sure errors show up when logs are on.
Risk
Low. Dashboard logs are off by default.
Regression?
Yes.