Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 11, 2024

Backport of #3595 to release/8.0

/cc @kvenkatrajan @drewnoakes

Customer Impact

Testing

Risk

Regression?

Microsoft Reviewers: Open in CodeFlow

Adds optional configuration that checks a given claim of a user authenticated via OIDC.

Two new configuration values are:

- `Dashboard:Frontend:OpenIdConnect:RequireClaimType` specifies the (optional) claim that be present for authorized users. Defaults to empty.
- `Dashboard:Frontend:OpenIdConnect:RequireClaimValue` specifies the (optional) value of the required claim. Only used if `Dashboard:Frontend:OpenIdConnect:RequireClaimType` is also specified. Defaults to empty.
@ghost ghost added the area-dashboard label Apr 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 11, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 11, 2024
@danmoseley
Copy link
Member

discussed offline, approved. please work with Bala or otherwise to mitigate risk after it goes in.

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faithful port

@danmoseley danmoseley enabled auto-merge (squash) April 11, 2024 23:01
@drewnoakes
Copy link
Member

I'm going to do some manual testing on this branch before it's merged.

@kvenkatrajan kvenkatrajan self-requested a review April 11, 2024 23:06
@danmoseley danmoseley merged commit 5ca550a into release/8.0 Apr 11, 2024
@danmoseley danmoseley deleted the backport/pr-3595-to-release/8.0 branch April 11, 2024 23:24
@drewnoakes
Copy link
Member

I'm going to do some manual testing on this branch before it's merged.

This was merged before my testing completed. I'm pushing a follow-up PR.

@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-dashboard Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants